[FC-0099] refactor: avoid duplicates when getting role scopes#137
[FC-0099] refactor: avoid duplicates when getting role scopes#137mariajgrimaldi merged 3 commits intomainfrom
Conversation
|
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
open-source-contribution
| # Subclasses like ContentLibraryData ('lib') represent concrete resource types with their own namespaces. | ||
| NAMESPACE: ClassVar[str] = "global" | ||
|
|
||
| def __eq__(self, other: "ScopeData") -> bool: |
There was a problem hiding this comment.
This looks good, but I'm not sure why the codecov report indicates that this method is uncovered.
There was a problem hiding this comment.
:o thanks for bringing this up! I'll look into it
There was a problem hiding this comment.
So @define already creates the correct eq, and since this is the parent of ContentLibraryData it gets overridden. I dropped it since we don't need it in this case :)
mariajgrimaldi
changed the title
5 participants
Description
This is a hot-fix cause I think this might be part of a bigger issue. This PR avoids duplicates when getting the scopes for a user role assignments. I hit some race condition and generated this which only affects this function, the rest API for role assignments / roles return the proper number of assignments though.
Could this be related to a stale read-before-write?
I'll ask internally to review the sanbodx database in case we somehow have duplicates- there are no duplicates. This is even more puzzling, I'll be testing this and openedx/openedx-platform#37564 in case there is something missing.Merge checklist:
Check off if complete or not applicable: